Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: add files entry to package.json #1724

Merged
merged 3 commits into from
Jun 29, 2023
Merged

Conversation

williaster
Copy link
Collaborator

@williaster williaster commented Jun 28, 2023

🐛 Bug Fix

The published contents of @visx/vendor are off in the first alpha version.

It seems like the default behavior should be to include all files, so this seems like the generated lib/, esm/, vendor-cjs/, index, and type files weren't published. Will do the following:

  • add explicit files entry to the package.json
  • debug why lib/, esm/, ... were not published
    • unclear, the github actions logs suggest everything was generated. validating this locally and will merge this with the simple files fix if it works locally

@williaster williaster merged commit f1c3552 into master Jun 29, 2023
@github-actions
Copy link

🎉 This PR is included in version v3.2.0 of the packages modified 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant